Solves issue with SwarmResult.agent AfterWorkOption -> str #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous constructor of SwarmResult converts AfterWorkOptions to a string. This causes exceptions when a function sets an AfterWorkOption as the next agent.
|
|
Collaborator
|
Thanks for the fix @ghoto! Looks good, if you can sign the CLA we'll get it merged! |
Collaborator
|
Just a note that we found a bug when processing the SwarmResult from the tool call, it was ignoring the AfterWorkOption. This fix has been put in this PR. |
marklysze
approved these changes
Feb 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous constructor of SwarmResult converts AfterWorkOptions to a string. This causes exceptions when a function sets an AfterWorkOption as the next agent.
Why are these changes needed?
The current constructor of SwarmResults converts AfterworkOption to
str. This causes exceptions when trying to select the next agent, because the str is compared against the list of all agents, but the agent doesn't exist.Related issue number
Checks