Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix rag query engine protocol #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2025
Merged

Fix rag query engine protocol #1197

merged 2 commits into from
Mar 2, 2025

Conversation

@AgentGenie
Copy link
Collaborator

@AgentGenie AgentGenie commented Mar 1, 2025

Why are these changes needed?

Fix protocol. One PR merged earlier caused misalignment.

Related issue number

Checks

@AgentGenie AgentGenie requested a review from Eric-Shang March 1, 2025 02:18
@marklysze marklysze enabled auto-merge March 1, 2025 04:13
Eric-Shang
Eric-Shang reviewed Mar 1, 2025
View reviewed changes
@marklysze marklysze mentioned this pull request Mar 2, 2025
Merged
3 tasks
@marklysze marklysze added this pull request to the merge queue Mar 2, 2025
Merged via the queue into main with commit 8af94f9 Mar 2, 2025
17 checks passed
@marklysze marklysze deleted the rag_protocol branch March 2, 2025 21:52
@codecov
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...experimental/document_agent/chroma_query_engine.py 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...experimental/document_agent/chroma_query_engine.py 34.14% <50.00%> (-1.22%) ⬇️

... and 38 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eric-Shang Eric-Shang Eric-Shang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AgentGenie @Eric-Shang @marklysze