Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: fix default value for max_round in group_chat_config section #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2025
Merged

chore: fix default value for max_round in group_chat_config section #1270

merged 1 commit into from
Mar 8, 2025

Conversation

@hexcow
Copy link
Contributor

@hexcow hexcow commented Mar 7, 2025

Description

I noticed a issue in the documentation for the group_chat_config section. The default value for the max_round parameter was incorrectly listed as 10, but it should actually be 15 according to the example configuration provided earlier.

Here’s the corrected version:

### `max_round`
Specifies the maximum number of rounds in a group chat session. Defaults to `15`.

This update should clarify the correct default value.

Why are these changes needed?

The default value for max_round in the group_chat_config section was listed incorrectly as 10. The correct default value, according to the example configuration, is 15. This change ensures the documentation is accurate and consistent.

Checks

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@marklysze
Copy link
Collaborator

marklysze commented Mar 7, 2025 •
edited
Loading

Hi @hexcow, at the moment the default for the max_round is 10 and the example config in the documentation shows that it can be set to 15. Understand this can be confusing, would you prefer to update the text to say "it defaults to 10 with the example above changing it to 15"?

@marklysze
Copy link
Collaborator

marklysze commented Mar 7, 2025

Oh, and can you let me know how you found that documentation as I'm not sure where it is in our docs site and we may need to set it up to be with our CaptainAgent page in Reference Agents.

@hexcow
Copy link
Contributor Author

hexcow commented Mar 7, 2025

Oh, and can you let me know how you found that documentation as I'm not sure where it is in our docs site and we may need to set it up to be with our CaptainAgent page in Reference Agents.

Right here:

Снимок экрана 2025-03-07 в 21 42 12

@marklysze
Copy link
Collaborator

marklysze commented Mar 8, 2025

Oh, and can you let me know how you found that documentation as I'm not sure where it is in our docs site and we may need to set it up to be with our CaptainAgent page in Reference Agents.

Right here:

Снимок экрана 2025-03-07 в 21 42 12

Thanks @hexcow, sorry I meant how did you get to the page itself? Was it from a Google search or from within the AG2 documentation pages? I'm just trying to work out if we have a link to the page.

@hexcow
Copy link
Contributor Author

hexcow commented Mar 8, 2025

sure

Google.

@marklysze
Copy link
Collaborator

marklysze commented Mar 8, 2025

sure

Google.

Perfect, thanks, let's merge this!

@marklysze marklysze enabled auto-merge March 8, 2025 21:33
@marklysze marklysze added this pull request to the merge queue Mar 8, 2025
Merged via the queue into ag2ai:main with commit 12e510e Mar 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marklysze marklysze marklysze approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hexcow @CLAassistant @marklysze