Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Agents name validation and error handling #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 22, 2025
Merged

Agents name validation and error handling #583

merged 11 commits into from
Jan 22, 2025

Conversation

@rjambrecic
Copy link
Collaborator

@rjambrecic rjambrecic commented Jan 21, 2025 •
edited
Loading

Why are these changes needed?

  • Validate names only for agents with openai LLM config
  • Raise more understandable error message if openai raises BadRequestError because of the name parameter

Related issue number

Closes #575

Checks

marklysze
marklysze reviewed Jan 22, 2025
View reviewed changes
@davorrunje davorrunje added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 392f9cf Jan 22, 2025
225 of 231 checks passed
@davorrunje davorrunje deleted the agents-name-validation branch January 22, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marklysze marklysze marklysze left review comments

@davorrunje davorrunje davorrunje approved these changes

Assignees

@davorrunje davorrunje

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove agents name validation for agents with non openai llm_config

4 participants

@rjambrecic @davorrunje @marklysze