Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove sensitive prints #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2025
Merged

Remove sensitive prints #799

merged 2 commits into from
Feb 4, 2025

Conversation

@sternakt
Copy link
Collaborator

@sternakt sternakt commented Feb 4, 2025

Why are these changes needed?

Remove the prints of conversations in tests, that potentially leak sensitive information, detected by github security scan

Related issue number

Closes #797

Checks

@sternakt sternakt requested a review from kumaranvpl February 4, 2025 08:47
@codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
3.10 55.98% <ø> (ø)
3.13 33.71% <ø> (ø)
3.9 52.01% <ø> (+18.80%) ⬆️
anthropic 37.56% <ø> (?)
deepseek 32.75% <ø> (?)
docs 28.86% <ø> (ø)
gemini 39.43% <ø> (?)
graph-rag-falkor-db 28.30% <ø> (ø)
interop 29.75% <ø> (ø)
jupyter-executor 31.02% <ø> (ø)
macos-latest 56.07% <ø> (ø)
openai 45.50% <ø> (?)
retrievechat 29.82% <ø> (ø)
retrievechat-mongodb 28.58% <ø> (ø)
retrievechat-pgvector 28.58% <ø> (ø)
retrievechat-qdrant 28.50% <ø> (ø)
twilio 28.51% <ø> (ø)
ubuntu-latest 63.88% <ø> (+7.81%) ⬆️
windows-latest 53.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 22 files with indirect coverage changes

@kumaranvpl kumaranvpl marked this pull request as draft February 4, 2025 08:59
@sternakt sternakt marked this pull request as ready for review February 4, 2025 09:01
@kumaranvpl kumaranvpl marked this pull request as draft February 4, 2025 10:02
@kumaranvpl kumaranvpl marked this pull request as ready for review February 4, 2025 10:02
@kumaranvpl kumaranvpl added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit cc74423 Feb 4, 2025
102 checks passed
@kumaranvpl kumaranvpl deleted the remove-logging-of-sensitive-info branch February 4, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaranvpl kumaranvpl kumaranvpl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove sensitive prints from testing

3 participants

@sternakt @kumaranvpl