Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove default code execution config from run executor agent #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2025
Merged

Remove default code execution config from run executor agent #853

merged 2 commits into from
Feb 7, 2025

Conversation

@marklysze
Copy link
Collaborator

@marklysze marklysze commented Feb 6, 2025 •
edited
Loading

Why are these changes needed?

Removes the hard coding of the code execution config on the internal agent created for ConversableAgents run` method.

If code execution is required, the code execution config can be passed in through the executor_kwargs parameter on run.

By defaulting it, this was causing issues with new users trying the quick start examples.

Related issue number

N/A

Checks

@marklysze marklysze requested a review from sonichi February 6, 2025 21:07
@marklysze marklysze self-assigned this Feb 6, 2025
@codecov
Copy link

codecov bot commented Feb 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
3.10 58.58% <ø> (+2.71%) ⬆️
3.11 30.78% <ø> (?)
3.12 27.60% <ø> (?)
3.13 42.51% <ø> (+7.85%) ⬆️
3.9 55.42% <ø> (+21.69%) ⬆️
anthropic 37.30% <ø> (?)
autobuild 17.57% <ø> (?)
bedrock 16.72% <ø> (?)
browser_use 29.38% <ø> (-0.01%) ⬇️
cerebras 16.43% <ø> (?)
cohere 16.48% <ø> (?)
crawl4ai 29.58% <ø> (-0.01%) ⬇️
deepseek 32.76% <ø> (?)
docs 28.57% <ø> (-0.01%) ⬇️
gemini 39.26% <ø> (?)
graph-rag-falkor-db 28.01% <ø> (-0.01%) ⬇️
groq 16.45% <ø> (?)
interop 29.44% <ø> (-0.01%) ⬇️
jupyter-executor 30.69% <ø> (-0.01%) ⬇️
lmm 19.78% <ø> (?)
long-context 15.59% <ø> (?)
macos-latest 58.93% <ø> (+2.64%) ⬆️
mistral 16.16% <ø> (?)
ollama 16.85% <ø> (?)
openai 45.11% <ø> (?)
retrievechat 29.56% <ø> (+0.03%) ⬆️
retrievechat-mongodb 29.55% <ø> (+1.26%) ⬆️
retrievechat-pgvector 29.55% <ø> (+1.26%) ⬆️
retrievechat-qdrant 29.50% <ø> (+1.28%) ⬆️
teachable 18.72% <ø> (?)
together 16.48% <ø> (?)
twilio 28.21% <ø> (-0.01%) ⬇️
ubuntu-latest 66.61% <ø> (+10.34%) ⬆️
websurfer 18.70% <ø> (?)
windows-latest 56.62% <ø> (+2.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
autogen/agentchat/conversable_agent.py 77.53% <ø> (+12.76%) ⬆️

... and 28 files with indirect coverage changes

@marklysze marklysze requested a review from davorrunje February 6, 2025 22:41
@marklysze marklysze added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 6debf2d Feb 7, 2025
313 checks passed
@marklysze marklysze deleted the removeruncodeexecution branch February 7, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davorrunje davorrunje davorrunje approved these changes

@sonichi sonichi Awaiting requested review from sonichi

Assignees

@marklysze marklysze

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marklysze @davorrunje