Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix failing neo4j graph rag tests #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 10, 2025
Merged

Fix failing neo4j graph rag tests #896

merged 4 commits into from
Feb 10, 2025

Conversation

@kumaranvpl
Copy link
Collaborator

@kumaranvpl kumaranvpl commented Feb 10, 2025 •
edited
Loading

Why are these changes needed?

Fix in test file is written based on - https://github.com/ag2ai/ag2/blob/main/test/agentchat/contrib/graph_rag/test_native_neo4j_graph_rag.py#L92C5-L96C48

Related issue number

Closes #895

Checks

@codecov
Copy link

codecov bot commented Feb 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
3.10 59.21% <ø> (+2.63%) ⬆️
3.11 29.75% <ø> (+14.51%) ⬆️
3.12 26.68% <ø> (?)
3.13 43.14% <ø> (+7.54%) ⬆️
3.9 56.17% <ø> (+20.88%) ⬆️
anthropic 37.08% <ø> (?)
autobuild 16.98% <ø> (?)
bedrock 16.16% <ø> (?)
browser-use 29.42% <ø> (ø)
cerebras 15.88% <ø> (?)
cohere 15.93% <ø> (?)
commsagent-discord 29.92% <ø> (ø)
commsagent-slack 29.90% <ø> (ø)
commsagent-telegram 29.85% <ø> (ø)
crawl4ai 29.62% <ø> (ø)
deepseek 32.35% <ø> (?)
docs 28.62% <ø> (ø)
falkordb ?
gemini 38.98% <ø> (?)
graph-rag-falkor-db 28.08% <ø> (ø)
groq 15.90% <ø> (?)
interop 29.48% <ø> (ø)
jupyter-executor 30.69% <ø> (ø)
lmm 19.12% <ø> (?)
long-context 15.07% <ø> (?)
macos-latest 59.59% <ø> (+2.57%) ⬆️
mistral 15.62% <ø> (?)
ollama 16.28% <ø> (?)
openai 44.60% <ø> (?)
retrievechat 29.59% <ø> (+0.04%) ⬆️
retrievechat-mongodb 29.58% <ø> (+1.22%) ⬆️
retrievechat-pgvector 29.58% <ø> (+1.22%) ⬆️
retrievechat-qdrant 29.53% <ø> (+1.24%) ⬆️
teachable 18.10% <ø> (?)
together 15.93% <ø> (?)
twilio 28.30% <ø> (ø)
ubuntu-latest 66.99% <ø> (+9.99%) ⬆️
websurfer 18.07% <ø> (?)
windows-latest 57.34% <ø> (+2.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 29 files with indirect coverage changes

@kumaranvpl kumaranvpl changed the title Fix neo4j graph rag tests Fix failing neo4j graph rag tests Feb 10, 2025
@kumaranvpl kumaranvpl added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit 078e5f3 Feb 10, 2025
341 checks passed
@kumaranvpl kumaranvpl deleted the fix-neo4j-graph-rag-tests branch February 10, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjambrecic rjambrecic rjambrecic approved these changes

Assignees

@rjambrecic rjambrecic

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix failing neo4j graph rag tests

3 participants

@kumaranvpl @rjambrecic