Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update captain agent tools #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2025
Merged

update captain agent tools #802

merged 2 commits into from
Feb 7, 2025

Conversation

@lazToum
Copy link
Collaborator

@lazToum lazToum commented Feb 4, 2025

Minor changes to captain agent tools

Why are these changes needed?

  • Fix "attempted relative import" (change from ......coding to from autogen.coding
  • Update image_qa: change requirement from PIL to pillow
  • Fix typo in "get_youtube_caption"

Related issue number

Checks

@lazToum lazToum requested a review from davorrunje February 4, 2025 12:45
@lazToum lazToum requested a review from kumaranvpl February 4, 2025 12:45
@codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
3.10 58.42% <ø> (+2.44%) ⬆️
3.11 29.14% <ø> (?)
3.12 27.39% <ø> (?)
3.13 41.58% <ø> (+7.88%) ⬆️
3.9 40.03% <ø> (+6.83%) ⬆️
anthropic 16.39% <ø> (?)
bedrock 16.77% <ø> (?)
cerebras 16.48% <ø> (?)
cohere 16.52% <ø> (?)
docs 28.86% <ø> (ø)
gemini 16.47% <ø> (?)
graph-rag-falkor-db 28.29% <ø> (ø)
groq 16.50% <ø> (?)
interop 29.75% <ø> (ø)
jupyter-executor 31.01% <ø> (ø)
lmm 19.36% <ø> (?)
long-context 15.62% <ø> (?)
macos-latest 58.48% <ø> (+2.40%) ⬆️
mistral 16.20% <ø> (?)
ollama 16.88% <ø> (?)
retrievechat 29.86% <ø> (+0.04%) ⬆️
retrievechat-mongodb 29.85% <ø> (+1.28%) ⬆️
retrievechat-pgvector 29.85% <ø> (+1.28%) ⬆️
retrievechat-qdrant 29.80% <ø> (+1.30%) ⬆️
teachable 15.80% <ø> (?)
together 16.53% <ø> (?)
twilio 28.50% <ø> (ø)
ubuntu-latest 58.50% <ø> (+2.44%) ⬆️
websurfer 18.75% <ø> (?)
windows-latest 56.11% <ø> (+2.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

@qingyun-wu qingyun-wu requested a review from LeoLjl February 5, 2025 08:58
@qingyun-wu
Copy link
Collaborator

qingyun-wu commented Feb 5, 2025

@lazToum Thanks for the proposed changes! @LeoLjl @LinxinS97 could you review this PR? Thank!

@qingyun-wu qingyun-wu requested a review from LinxinS97 February 5, 2025 08:58
kumaranvpl
kumaranvpl previously requested changes Feb 5, 2025
View reviewed changes
@kumaranvpl
Copy link
Collaborator

kumaranvpl commented Feb 5, 2025

@qingyun-wu This PR has too many unnecessary changes and changing PIL to pillow which is completely wrong.

@lazToum lazToum requested a review from kumaranvpl February 5, 2025 13:19
@lazToum
Copy link
Collaborator Author

lazToum commented Feb 5, 2025 •
edited
Loading

@qingyun-wu This PR has too many unnecessary changes and changing PIL to pillow which is completely wrong.

Thanks @kumaranvpl for the review.

  • If I did not get the "attempted relative import" error I would not change them.
  • Same for pillow. If I didn't get a "No matching distribution found for PIL" I wouldn't change it.
    For example, in tools/information_retrieval/transcribe_audio_file.py we use @with_requirements(["openai-whisper"]) (the package) and not "whisper" (what to import).

@kumaranvpl
Copy link
Collaborator

kumaranvpl commented Feb 5, 2025

@lazToum @qingyun-wu My bad. I got require_optional_import confused with with_requirements as both are similar.

LeoLjl
LeoLjl approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@LeoLjl LeoLjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me.

@LeoLjl LeoLjl enabled auto-merge February 6, 2025 18:48
@davorrunje
Copy link
Collaborator

davorrunje commented Feb 6, 2025

  • with_requirements

I will merge this, but we plan to deprecate with_requirements and replace it with require_optional_import in the future.

@LeoLjl LeoLjl added this pull request to the merge queue Feb 6, 2025
@davorrunje davorrunje self-assigned this Feb 6, 2025
Merged via the queue into main with commit 95daf1b Feb 7, 2025
295 of 302 checks passed
@LeoLjl LeoLjl deleted the update_captain_agent_tools branch February 7, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davorrunje davorrunje davorrunje approved these changes

@LeoLjl LeoLjl LeoLjl approved these changes

@LinxinS97 LinxinS97 Awaiting requested review from LinxinS97

@kumaranvpl kumaranvpl Awaiting requested review from kumaranvpl

Assignees

@davorrunje davorrunje

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lazToum @qingyun-wu @kumaranvpl @davorrunje @LeoLjl