Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Hotfix failing isinstance checks for swarmable agent #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 4, 2025
Merged

Hotfix failing isinstance checks for swarmable agent #804

merged 4 commits into from
Feb 4, 2025

Conversation

@sternakt
Copy link
Collaborator

@sternakt sternakt commented Feb 4, 2025

Why are these changes needed?

This will add the export_module attribute to SwarmableAgent to ensure that it implements the Agent protocol and isinstance(SwarmableAgent, Agent) returns true

Related issue number

Closes #803

Checks

@codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
3.10 58.42% <100.00%> (+2.44%) ⬆️
3.11 30.64% <0.00%> (?)
3.12 27.39% <0.00%> (?)
3.13 41.88% <100.00%> (+8.18%) ⬆️
3.9 48.89% <100.00%> (+15.69%) ⬆️
anthropic 37.68% <100.00%> (?)
autobuild 17.61% <0.00%> (?)
bedrock 16.76% <0.00%> (?)
cerebras 16.48% <0.00%> (?)
cohere 16.52% <0.00%> (?)
deepseek 32.75% <100.00%> (?)
docs 28.86% <100.00%> (+<0.01%) ⬆️
gemini 39.56% <100.00%> (?)
graph-rag-falkor-db 28.30% <100.00%> (+<0.01%) ⬆️
groq 16.49% <0.00%> (?)
interop 29.75% <100.00%> (+<0.01%) ⬆️
jupyter-executor 31.02% <100.00%> (+<0.01%) ⬆️
lmm 19.85% <0.00%> (?)
long-context 15.62% <0.00%> (?)
macos-latest 58.48% <100.00%> (+2.40%) ⬆️
mistral 16.20% <0.00%> (?)
ollama 16.88% <0.00%> (?)
retrievechat 29.87% <100.00%> (+0.04%) ⬆️
retrievechat-mongodb 29.86% <100.00%> (+1.28%) ⬆️
retrievechat-pgvector 29.86% <100.00%> (+1.28%) ⬆️
retrievechat-qdrant 29.80% <100.00%> (+1.31%) ⬆️
teachable 18.78% <0.00%> (?)
together 16.53% <0.00%> (?)
twilio 28.51% <100.00%> (+<0.01%) ⬆️
ubuntu-latest 63.01% <100.00%> (+6.95%) ⬆️
websurfer 18.75% <0.00%> (?)
windows-latest 56.12% <100.00%> (+2.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../agentchat/realtime/experimental/realtime_swarm.py 65.17% <100.00%> (+37.67%) ⬆️

... and 21 files with indirect coverage changes

@kumaranvpl kumaranvpl added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 56d871a Feb 4, 2025
301 of 303 checks passed
@kumaranvpl kumaranvpl deleted the hotfix_failing_isinstance_checks_for_swarmable_agent branch February 4, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaranvpl kumaranvpl kumaranvpl approved these changes

@davorrunje davorrunje Awaiting requested review from davorrunje

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: RealtimeAgent swarm failing to start

3 participants

@sternakt @kumaranvpl