Fix failing CI tests in forked repo PRs #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
Check change
davorrunje
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
By default, PRs from forks does not has permission to access secrets. So, the tests fail for PR from fork making the maintainers life tougher for making sure that the contributor doesn't make any breaking changes.
To prevent this, we should be able to provide access to secrets for PRs from forks in a safew way. This changes are written based on - https://michaelheap.com/access-secrets-from-forks/.
The jobs checks out the code only if a person with write access to repository approved the CI job run. This requires carefully reading the changes before approving the CI run.
@davorrunje I could add a extra step to check whether a PR from fork has a label called "safe to test" which should be added by maintainer after reviewing the code
Related issue number
Closes #399
Checks