From 63373381867761cd8abdb9db154ebb0d679d6c8d Mon Sep 17 00:00:00 2001 From: mihran113 Date: Tue, 11 Feb 2025 19:00:46 +0400 Subject: [PATCH 01/10] [fix] Move performance tests to local mac mini --- .github/workflows/pull-request.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 348ab9349..46fc96103 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -68,8 +68,8 @@ jobs: storage-performance-checks: needs: run-checks - concurrency: perf-tests - runs-on: [self-hosted, performance-tests] + concurrency: storage-performance-checks + runs-on: [self-hosted, perf-tests] name: Performance tests steps: - name: checkout From f7a76a968df355293f950d46c7a118b59c870b2a Mon Sep 17 00:00:00 2001 From: mihran113 Date: Tue, 11 Feb 2025 19:02:29 +0400 Subject: [PATCH 02/10] Temporarily disable unit tests --- .github/workflows/pull-request.yml | 68 +++++++++++++++--------------- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 46fc96103..da699399a 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -32,42 +32,42 @@ jobs: # with: # regex: '^\[(?:feat|fix|doc|refactor|deprecation)\]\s[A-Z].*(? Date: Tue, 11 Feb 2025 19:55:17 +0400 Subject: [PATCH 03/10] Black magic --- .github/workflows/pull-request.yml | 5 ++--- performance_tests/requirements.txt | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index da699399a..0ec49995e 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -82,9 +82,8 @@ jobs: run: | python3 -m venv venv . venv/bin/activate - python -m pip install --upgrade pip - python -m pip install -r requirements.dev.txt - python -m pip install -r performance_tests/requirements.txt + pip install --upgrade pip + pip install -e . - name: perf tests run: | diff --git a/performance_tests/requirements.txt b/performance_tests/requirements.txt index 32cf989c4..1439d15df 100644 --- a/performance_tests/requirements.txt +++ b/performance_tests/requirements.txt @@ -1,4 +1,3 @@ --r ../requirements.txt boto3 pytest parameterized==0.8.1 From e1e7fded4ff2723ad02db33a8b283f55805ac6a7 Mon Sep 17 00:00:00 2001 From: mihran113 Date: Tue, 11 Feb 2025 19:59:23 +0400 Subject: [PATCH 04/10] More black magic --- .github/workflows/pull-request.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 0ec49995e..a0726594e 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -83,6 +83,7 @@ jobs: python3 -m venv venv . venv/bin/activate pip install --upgrade pip + pip install -r performance_tests/requirements.txt pip install -e . - name: perf tests From 8b2710d90de358548deb0deddcd53a278845fe76 Mon Sep 17 00:00:00 2001 From: mihran113 Date: Tue, 11 Feb 2025 20:02:19 +0400 Subject: [PATCH 05/10] Try non-editable install --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index a0726594e..a3084cb70 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -84,7 +84,7 @@ jobs: . venv/bin/activate pip install --upgrade pip pip install -r performance_tests/requirements.txt - pip install -e . + pip install . - name: perf tests run: | From 97dd87fa6255c2b11e775989e681343f57993a03 Mon Sep 17 00:00:00 2001 From: mihran113 Date: Tue, 11 Feb 2025 20:18:07 +0400 Subject: [PATCH 06/10] Revert black magic --- .github/workflows/pull-request.yml | 6 +++--- performance_tests/requirements.txt | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index a3084cb70..da699399a 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -82,9 +82,9 @@ jobs: run: | python3 -m venv venv . venv/bin/activate - pip install --upgrade pip - pip install -r performance_tests/requirements.txt - pip install . + python -m pip install --upgrade pip + python -m pip install -r requirements.dev.txt + python -m pip install -r performance_tests/requirements.txt - name: perf tests run: | diff --git a/performance_tests/requirements.txt b/performance_tests/requirements.txt index 1439d15df..32cf989c4 100644 --- a/performance_tests/requirements.txt +++ b/performance_tests/requirements.txt @@ -1,3 +1,4 @@ +-r ../requirements.txt boto3 pytest parameterized==0.8.1 From d0ca56b4053cc4220a50ea22281ae644f431f17c Mon Sep 17 00:00:00 2001 From: mihran113 Date: Tue, 11 Feb 2025 20:27:40 +0400 Subject: [PATCH 07/10] Init perf repos --- performance_tests/conftest.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/performance_tests/conftest.py b/performance_tests/conftest.py index a53afa2e7..4a4c30348 100644 --- a/performance_tests/conftest.py +++ b/performance_tests/conftest.py @@ -39,11 +39,7 @@ def _cleanup_test_repo(path): def pytest_sessionstart(session): - if os.environ.get('AIM_LOCAL_PERFORMANCE_TEST'): - _init_test_repos() - else: - # github actions performance tests on self hosted runner - os.chdir('/home/ubuntu/performance_logs/') + _init_test_repos() time.sleep(10) From 9bfabd4376e8a484894c88996c50fa846bd218c1 Mon Sep 17 00:00:00 2001 From: mihran113 Date: Tue, 11 Feb 2025 20:37:21 +0400 Subject: [PATCH 08/10] Use existing perf logs --- performance_tests/conftest.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/performance_tests/conftest.py b/performance_tests/conftest.py index 4a4c30348..95fa82005 100644 --- a/performance_tests/conftest.py +++ b/performance_tests/conftest.py @@ -39,7 +39,11 @@ def _cleanup_test_repo(path): def pytest_sessionstart(session): - _init_test_repos() + if os.environ.get('AIM_LOCAL_PERFORMANCE_TEST'): + _init_test_repos() + else: + # github actions performance tests on self hosted runner + os.chdir('/Users/github/workers/perf-tests/actions-runner/_work/performance_logs') time.sleep(10) From a7643739d58b219653034431598915f356a2d26f Mon Sep 17 00:00:00 2001 From: mihran113 Date: Thu, 13 Feb 2025 17:37:27 +0400 Subject: [PATCH 09/10] Update baselines --- performance_tests/BASELINE | 42 +++++++++++++++++++------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/performance_tests/BASELINE b/performance_tests/BASELINE index 1f403fadb..ebe22e938 100644 --- a/performance_tests/BASELINE +++ b/performance_tests/BASELINE @@ -1,21 +1,21 @@ -test_collect_metrics_data_0 1.8545958518981933 -test_collect_metrics_data_1 1.9959398269653321 -test_collect_metrics_data_2 10.835494375228881 -test_collect_metrics_data_3 1.8672633171081543 -test_collect_runs_data_0 0.8988437175750732 -test_collect_runs_data_1 1.039186429977417 -test_collect_runs_data_2 3.469265604019165 -test_collect_runs_data_3 0.9486905574798584 -test_query_metrics_0 1.6766140460968018 -test_query_metrics_1 1.6763684749603271 -test_query_metrics_2 1.6051365375518798 -test_query_metrics_3 1.5391615390777589 -test_query_runs_0 0.8991998672485352 -test_query_runs_1 0.9259328842163086 -test_query_runs_2 0.839762544631958 -test_query_runs_3 0.832861852645874 -test_container_open 0.1440361499786377 -test_iterative_access 4.000607919692993 -test_random_access_0 0.663770055770874 -test_random_access_1 1.4745195388793946 -test_random_access_2 2.424658107757568 \ No newline at end of file +test_collect_metrics_data_0 0.3717397689819336 +test_collect_metrics_data_1 0.3963047981262207 +test_collect_metrics_data_2 2.7405614376068117 +test_collect_metrics_data_3 0.3710219860076904 +test_collect_runs_data_0 0.17322354316711425 +test_collect_runs_data_1 0.20246338844299316 +test_collect_runs_data_2 0.7970072269439697 +test_collect_runs_data_3 0.1911233901977539 +test_query_metrics_0 0.311903190612793 +test_query_metrics_1 0.3122593879699707 +test_query_metrics_2 0.3092495441436768 +test_query_metrics_3 0.288785982131958 +test_query_runs_0 0.17433061599731445 +test_query_runs_1 0.17484822273254394 +test_query_runs_2 0.17181901931762694 +test_query_runs_3 0.1616499423980713 +test_container_open 0.04026708602905273 +test_iterative_access 1.1857992172241212 +test_random_access_0 0.14068403244018554 +test_random_access_1 0.26419754028320314 +test_random_access_2 0.3941319942474365 \ No newline at end of file From 83a4ad3419801abefa15be397fcdb0a8662efe96 Mon Sep 17 00:00:00 2001 From: mihran113 Date: Thu, 13 Feb 2025 18:10:27 +0400 Subject: [PATCH 10/10] Enable and fix unit-tests --- .github/workflows/pull-request.yml | 68 +++++++++++++++--------------- tests/requirements.txt | 1 + 2 files changed, 35 insertions(+), 34 deletions(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index da699399a..46fc96103 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -32,42 +32,42 @@ jobs: # with: # regex: '^\[(?:feat|fix|doc|refactor|deprecation)\]\s[A-Z].*(?=0.87.0 httpx