Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Overlays with open={true} by default don't render #379

@etr2460

Description

@etr2460

I believe the change made in #287 resulted in Overlays not rendering if the open param is set to true initially. This seems to be because the Overlay doesn't render its children until it updates once, and if we initialize open to true then it never updates.

You should be able to repro this with a simple case like:

<Overlay open={true} onClose={() => undefined}>
  <div>This doesn't display</div>
</Overlay>

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions