-
Notifications
You must be signed in to change notification settings - Fork 33
Comparing changes
Open a pull request
base repository: hjoykim/THREE
base: master
head repository: akav/THREE
compare: master
- 15 commits
- 36 files changed
- 1 contributor
Commits on Feb 22, 2025
-
Refactor property access and improve code readability
Updated property access in `GLRenderer.cs` and `GLBindingStates.cs` to use consistent naming conventions. Enhanced `GLPrograms.cs` with null-conditional operators and pattern matching for safer property access and simplified type checks. Refactored parameter addition to `Hashtable` using collection initializer syntax for improved readability and maintainability.
Configuration menu - View commit details
-
Copy full SHA for 69543c4 - Browse repository at this point
Copy the full SHA 69543c4View commit details -
Refactor geometry updates and add dimension checks
- Refactored `Update` method in `GLGeometries.cs` to ensure geometry is of type `BufferGeometry` and handle `BufferAttribute` updates using a switch statement. - Added dimension checks in `InitCamera` of `BuffergeometryExample.cs` and `InstancingDynamic.cs` to prevent invalid camera initialization. - Implemented a safeguard in `LinesFatExample.cs` to avoid division by zero when calculating aspect ratio for `camera2`.
Configuration menu - View commit details
-
Copy full SHA for 0066074 - Browse repository at this point
Copy the full SHA 0066074View commit details -
Add null check for example info before loading
Implemented a null check for the variable `e` to ensure that the `currentExample` is only instantiated and loaded if `e` is not null. If `e` is null, a message "Invalid example info." is logged to the console to prevent null reference exceptions.
Configuration menu - View commit details
-
Copy full SHA for ee57834 - Browse repository at this point
Copy the full SHA ee57834View commit details -
Upgrade projects to target .NET 9.0
Updated multiple project files to target .NET 9.0 instead of .NET 8.0, including changes to the `TargetFramework` property in `FormsDemo`, `SilkDemo`, `SingleFormsDemo`, `SingleSceneSilkExample`, `THREE.OpenGL`, `THREE.Silk`, `THREE`, `THREESilkExample`, `WPFDemo`, and `WSLDemo`. Retained and reformatted assembly metadata in `THREE.csproj`, while preserving the `AllowUnsafeBlocks` property. Some project and package references were modified or removed, indicating a cleanup of dependencies. The `OutputType` for `FormsDemo` and `SingleFormsDemo` was changed to `WinExe`, and the `WPFDemo` project was updated to align with the new target framework. These changes enhance compatibility with the latest .NET framework, potentially improving performance and modernizing development practices.
Configuration menu - View commit details
-
Copy full SHA for c193141 - Browse repository at this point
Copy the full SHA c193141View commit details -
Add NuGet packages and update existing dependencies
- Added `System.Net.Http`, `System.Text.RegularExpressions`, and `System.Text.Json` to multiple projects. - Updated versions of `Pfim`, `SkiaSharp`, and `StbImageSharp` in `THREE.csproj`. - Reformatted method signature for `ToSKBitMap` in `ImageExtension.cs` for consistency.
Configuration menu - View commit details
-
Copy full SHA for 8a2dc2c - Browse repository at this point
Copy the full SHA 8a2dc2cView commit details -
Revert "Add NuGet packages and update existing dependencies"
This reverts commit 8a2dc2c.
Configuration menu - View commit details
-
Copy full SHA for b3595c7 - Browse repository at this point
Copy the full SHA b3595c7View commit details -
Update package versions and improve UI interactions
- Upgraded `ImGui.NET` to version `1.91.6.1` in multiple projects. - Updated `Silk.NET` packages to version `2.22.0` in `THREE.Silk.csproj`. - Changed `Pfim` version to `0.11.3` in `THREE.csproj`. - Updated `StbImageSharp` to version `2.30.15` in `THREE.csproj`. - Modified `ImGui.Selectable` method calls for better UI behavior.
Configuration menu - View commit details
-
Copy full SHA for bc3d1d4 - Browse repository at this point
Copy the full SHA bc3d1d4View commit details -
Remove zero-dimension check in InitCamera method
The check for non-zero dimensions in the ClientRectangle has been removed from the InitCamera method. This change eliminates the `InvalidOperationException` that was thrown when either width or height was zero, while keeping the camera initialization logic intact.
Configuration menu - View commit details
-
Copy full SHA for f166381 - Browse repository at this point
Copy the full SHA f166381View commit details -
Refactor mouse event handling and improve code clarity
- Removed and added mouse event handlers in Form1.Designer.cs for better event management. - Introduced constants and a new LoadTexture method in DisplacementMapExample.cs to enhance readability and maintainability. - Updated Init and Render methods in CinematicCameraExample.cs to improve scene setup and GUI control handling. - Overall focus on improving code structure, readability, and user interaction capabilities.
Configuration menu - View commit details
-
Copy full SHA for 8706c98 - Browse repository at this point
Copy the full SHA 8706c98View commit details
Commits on Feb 23, 2025
-
Configuration menu - View commit details
-
Copy full SHA for c731512 - Browse repository at this point
Copy the full SHA c731512View commit details -
Update dependencies and clean up code
- Deleted the `nuget.exe` binary file. - Modified `ToSKBitMap` method signature and delegate in `ImageExtension.cs`. - Removed commented-out methods in `ImageExtension.cs`. - Updated `SkiaSharp` and `SkiaSharp.NativeAssets.Linux` versions in `THREE.csproj` and `WSLDemo.csproj`. - Ensured consistent formatting for `glControl` in `Example.cs`. - Simplified `InitCamera` method in `BuffergeometryExample.cs` to use `glControl.AspectRatio`.
Configuration menu - View commit details
-
Copy full SHA for 674aefc - Browse repository at this point
Copy the full SHA 674aefcView commit details -
Revert "Update dependencies and clean up code"
This reverts commit 674aefc.
Configuration menu - View commit details
-
Copy full SHA for 50f96a9 - Browse repository at this point
Copy the full SHA 50f96a9View commit details -
Refactor InitCamera method in BuffergeometryExample
Removed dimension check for glControl and updated aspect ratio calculation to use glControl.AspectRatio directly.
Configuration menu - View commit details
-
Copy full SHA for f569ecc - Browse repository at this point
Copy the full SHA f569eccView commit details -
Update OpenTK references and GLControl usage
Refactor GLControl usage by replacing `OpenTK.WinForms.GLControl` with `OpenTK.GLControl.GLControl` for improved compatibility with .NET 6.0. Update OpenTK and related package versions to 4.9.3 and 4.0.2. Remove conditional compilation directives for a unified codebase. Adjust method calls to align with the updated OpenTK API. Remove `nuget.exe` to streamline package management with .NET CLI. These changes modernize the codebase and enhance OpenGL rendering capabilities.
Configuration menu - View commit details
-
Copy full SHA for 6c8414c - Browse repository at this point
Copy the full SHA 6c8414cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b355b11 - Browse repository at this point
Copy the full SHA b355b11View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master