Improve handling of response body sizes #343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove consideration of `Connection: close` in determining response body size. A response can have Content-Length in addition to Connection: close. Remove consideration of HTTP version. An HTTP/1.0 response can have a Content-Length. Add consideration of Transfer-Encoding, which is specified to take precedence over Content-Length. No-body response codes take precedence over any Transfer-Encoding that might be present, and enforce a body size of 0. Explicitly reject a Content-Length header on no-body response codes.
algesten
reviewed
Mar 14, 2021
| Box::new(PoolReturnRead::new(unit, LimitedRead::new(stream, 0))) | ||
| } | ||
| (true, _) => { | ||
| trace!("building ChunkDecoder"); |
Owner
There was a problem hiding this comment.
maybe all these trace! logs can be on the form "Using ChunkDecoder", "Using LimitRead with limit {}", etc.
Collaborator
Author
|
Obsoleted by #625 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove consideration of
Connection: closein determining response bodysize. A response can have Content-Length in addition to Connection:
close.
Remove consideration of HTTP version. An HTTP/1.0 response can have a
Content-Length.
Add consideration of Transfer-Encoding, which is specified to take
precedence over Content-Length.
No-body response codes take precedence over any Transfer-Encoding that
might be present, and enforce a body size of 0.
Explicitly reject a Content-Length header on no-body response codes.
I noticed this when testing against a server that sent
HTTP/1.0,Connection: close, and aContent-Length, but didn't actually close the connection; this caused cureq to wait indefinitely.Draft because I need to write unit tests.