Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@liqipeng
Copy link
Contributor

@liqipeng liqipeng commented Apr 1, 2022

Change implementation of JacksonUtils methods about byte operation to reduce memory cost, especially when DistroProtocol fetching full data from peer node in the initialization phase. (#8072)

What is the purpose of the change

详见:#8072

Brief changelog

Reduce memory cost in DistroProtocol initialization to avoid OOM

Verifying this change

Unit tests for changes have been added.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

… reduce memory cost, especially when DistroProtocol fetching full data from peer node in the initialization phase. (alibaba#8072)
@KomachiSion KomachiSion merged commit 1c20ebe into alibaba:v1.x-develop Apr 6, 2022
@KomachiSion KomachiSion added this to the 1.4.4 milestone Apr 6, 2022
CherishCai pushed a commit to CherishCai/nacos that referenced this pull request Apr 12, 2022
… reduce memory cost, especially when DistroProtocol fetching full data from peer node in the initialization phase. (alibaba#8072) (alibaba#8075)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants