Release 2019.2.0 #578
Merged
Release 2019.2.0 #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simogasp
reviewed
Aug 8, 2019
| psutil | ||
| enum34;python_version<"3.4" | ||
| PySide2==5.11.1 | ||
| PySide2==5.13.0 |
There was a problem hiding this comment.
is it mandatory or 5.12 can work as well?
There was a problem hiding this comment.
Yes, 5.12 is compatible.
We use 5.13 here to match the version we will use to make the release binaries.
There was a problem hiding this comment.
ok, can we add a line in INSTALL.md with the minimum qt version supported and warning to have a matching version between qt and pyside?
E.g. here https://github.com/alicevision/meshroom/blob/develop/INSTALL.md#python-environment adding another bullet:
* Qt and PySide 5.X.Y. To install the latest supported version of PySide, you can use `requirements.txt` as described below, or you can manually install the version that matches the Qt version installed in your system.7d52c5b to
fe17c61
Compare
yann-lty
approved these changes
Aug 9, 2019
bump to 5.13.0
e70480b to
1fce38a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AliceVision 2.2.0 release: alicevision/AliceVision#670