Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Promote Grid Visualization #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Promote Grid Visualization #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions src/common/models/essence/essence.mocha.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import { expect } from "chai";
import { SinonSpy, spy, stub } from "sinon";
import { BAR_CHART_MANIFEST } from "../../visualization-manifests/bar-chart/bar-chart";
import { GRID_MANIFEST } from "../../visualization-manifests/grid/grid";
import { LINE_CHART_MANIFEST } from "../../visualization-manifests/line-chart/line-chart";
import { TABLE_MANIFEST } from "../../visualization-manifests/table/table";
import { TOTALS_MANIFEST } from "../../visualization-manifests/totals/totals";
Expand Down Expand Up @@ -125,7 +126,7 @@ describe("EssenceProps", () => {
sort: new DimensionSort({ reference: "twitterHandle" })
})],
series, current: TOTALS_MANIFEST,
expected: TABLE_MANIFEST
expected: GRID_MANIFEST
},
{
splits: [new Split({
Expand Down Expand Up @@ -176,11 +177,11 @@ describe("EssenceProps", () => {
expect(essence.visResolve.isReady()).to.be.true;
});

it("defaults to table with non continuous dimension", () => {
it("defaults to grid with non continuous dimension", () => {
const essence = EssenceFixtures.twitterNoVisualisation()
.changeVisualization(TOTALS_MANIFEST)
.addSplit(twitterHandleSplit, VisStrategy.FairGame);
expect(essence.visualization).to.deep.equal(TABLE_MANIFEST);
expect(essence.visualization).to.deep.equal(GRID_MANIFEST);
expect(essence.visResolve.isReady()).to.be.true;
});

Expand Down Expand Up @@ -226,7 +227,7 @@ describe("EssenceProps", () => {
const noMeasuresTests = [
{ splits: [timeSplit], visualization: LINE_CHART_MANIFEST },
{ splits: [tweetLengthSplit], visualization: BAR_CHART_MANIFEST },
{ splits: [twitterHandleSplit], visualization: TABLE_MANIFEST }
{ splits: [twitterHandleSplit], visualization: GRID_MANIFEST }
];

noMeasuresTests.forEach(({ splits, visualization }) => {
Expand Down Expand Up @@ -256,14 +257,10 @@ describe("EssenceProps", () => {
});

it("should handle adding too many splits for table", () => {
console.log("start it");
const essence = EssenceFixtures.wikiTable();
console.log("splits before", essence.splits.length());
const addedSplit = essence.addSplit(timeSplit, VisStrategy.KeepAlways);
console.log("splits after", addedSplit.splits.length());

expect(addedSplit.splits.length()).to.be.eq(5);
console.log("visResolve", addedSplit.visResolve.state);
expect(addedSplit.visResolve.isManual()).to.be.true;
expect(addedSplit.visResolve.resolutions[0].adjustment.splits.length()).to.be.eq(4);
});
Expand Down
4 changes: 2 additions & 2 deletions src/common/visualization-manifests/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ import { TOTALS_MANIFEST } from "./totals/totals";

export const MANIFESTS: VisualizationManifest[] = [
TOTALS_MANIFEST,
TABLE_MANIFEST,
GRID_MANIFEST,
LINE_CHART_MANIFEST,
BAR_CHART_MANIFEST,
HEAT_MAP_MANIFEST,
GRID_MANIFEST
TABLE_MANIFEST
];

export function manifestByName(visualizationName: string): VisualizationManifest {
Expand Down