resolve #116 #117
Merged
resolve #116 #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Since |
…teFromProps with added componentDidUpdate functionality
amio
reviewed
Dec 10, 2018
Owner
amio
left a comment
There was a problem hiding this comment.
Thanks @lluisrojass , just a few refinements
src/carousel.js
Outdated
| if (this.state.frames.length && this.state.frames.length !== prevState.frames.length) { | ||
| // reset to default state | ||
| this.hideFrames() | ||
| translateXY(this.refs['f0'], 0, 0, 0) |
Owner
There was a problem hiding this comment.
Should use this.prepareAutoSlide() instead of translateXY(this.refs['f0'], 0, 0, 0) to get all frames positioned correctly.
Contributor
Author
There was a problem hiding this comment.
@amio just noticed the comments :/ will be able to get to it within 24 hours, thanks for the patience and I apologize for the latency.
src/carousel.js
Outdated
| if (frames.length && frames.length !== prevState.frames.length) { | ||
| nextState.current = 0 | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@amio this has been addressed in latest commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #116
componentWillReceivePropswill now reset frames to default state upon receiving an array of frames differing fromstateframes.