fix(devtools): prevent root router from showing active when child rou… #63499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@MeAkib Thanks for opening this, will take a look today 🙏 |
|
Hi @MeAkib, after reviewing I think the correct way to solve this problem is to make it more clear to the user that the "Root" of the router is not a route config that the user is providing. Something like this here #63978 Alternatively we could remove the root entirely and have the initial routes in an application all be their own distinct trees in the graph. |
|
We'll pick up the fix from there. Thanks for the suggestion though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #63490
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:
#63490
What is the new behavior?
Does this PR introduce a breaking change?
Other information