CHORE: Handle fpdf2 in CI and extend README #6841
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6841 +/- ##
=======================================
Coverage 83.49% 83.49%
=======================================
Files 245 245
Lines 77525 77525
=======================================
+ Hits 64731 64733 +2
+ Misses 12794 12792 -2 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to a recent discussion with @maxcapodi78. We should have had a failure in CI due to the check licenses feature. However, the action had a bug that was fixed in ansys/actions#1046.
A new release should be proposed by dependabot this weekend with the associated fix and, to prepare for it, we need to update the project accordingly. The changes consist in adding
fpdf2to the whitelist since it is under LGPLv3 and extending the README documentation to highlight that optional project usage.Issue linked
None
Checklist