FIX: issue 1507 fix #1531
Merged
FIX: issue 1507 fix #1531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue 1507 by fixing the boundary_type property handling in the PadstackInstanceTerminal class. The changes improve the setter method to handle both string and enum values properly.
- Removes duplicate boundary_type property getter that was overriding the parent implementation
- Updates the boundary_type setter to handle both string and enum inputs more robustly
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
For more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (62.50%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1531 +/- ##
==========================================
- Coverage 73.03% 73.02% -0.01%
==========================================
Files 256 256
Lines 38567 38571 +4
==========================================
+ Hits 28166 28168 +2
- Misses 10401 10403 +2 🚀 New features to boost your workflow:
|
gkorompi
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue 1507
closing #1507