Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: πŸ› char ghosting when edit text (#2560) #3043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2022
Merged

fix: πŸ› char ghosting when edit text (#2560) #3043

merged 2 commits into from
Dec 16, 2022

Conversation

@wander-sky
Copy link
Contributor

Description

edit status char ghosting.

clear display value when edit status because char ghosting.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Dec 13, 2022 •
edited
Loading

Codecov Report

Merging #3043 (176cb4e) into master (1089109) will not change coverage.
The diff coverage is 20.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3043   +/-   ##
=======================================
  Coverage   33.19%   33.19%           
=======================================
  Files         274      274           
  Lines       17790    17790           
  Branches     3842     3842           
=======================================
  Hits         5906     5906           
  Misses      11477    11477           
  Partials      407      407
Flag Coverage Ξ”
x6 18.56% <20.00%> (ΓΈ)
x6-common 63.60% <ΓΈ> (ΓΈ)
x6-geometry 55.58% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
packages/x6/src/registry/tool/editor.ts 14.67% <20.00%> (ΓΈ)

NewByVector
NewByVector reviewed Dec 16, 2022
View reviewed changes
Copy link
Contributor

@NewByVector NewByVector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In what scenarios does char ghosting occur?

@wander-sky
Copy link
Contributor Author

image
image
https://github.com/antvis/X6/issues/2560

NewByVector
NewByVector requested changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@NewByVector NewByVector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your solution does solve the ghost problem,There are two small improvements:

  1. Add a determination of whether setText is a function
  2. The setText is extracted from the common method because the file uses the same functionality in two places

wander-sky
wander-sky commented Dec 16, 2022
View reviewed changes
Copy link
Contributor Author

@wander-sky wander-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right

@x6-bot x6-bot bot added size/S and removed size/XS labels Dec 16, 2022
@NewByVector NewByVector merged commit 15284e7 into antvis:master Dec 16, 2022
@x6-bot
Copy link
Contributor

x6-bot bot commented Dec 16, 2022

πŸŽ‰ This PR is included in the following release πŸŽ‰

Thanks for being a part of the AntV community! πŸ’ͺπŸ’―

@x6-bot x6-bot bot added the released label Dec 16, 2022
@wander-sky wander-sky deleted the dev branch December 17, 2022 08:40
@x6-bot
Copy link
Contributor

x6-bot bot commented Dec 20, 2022

πŸŽ‰ This PR is included in the following release πŸŽ‰

Thanks for being a part of the AntV community! πŸ’ͺπŸ’―

@x6-bot
Copy link
Contributor

x6-bot bot commented Jan 17, 2023

πŸŽ‰ This PR is included in the following release πŸŽ‰

Thanks for being a part of the AntV community! πŸ’ͺπŸ’―

@x6-bot
Copy link
Contributor

x6-bot bot commented Feb 17, 2023

πŸŽ‰ This PR is included in the following release πŸŽ‰

Thanks for being a part of the AntV community! πŸ’ͺπŸ’―

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NewByVector NewByVector NewByVector approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wander-sky @NewByVector