Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: add padding options for position api #3225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2023
Merged

fix: add padding options for position api #3225

merged 1 commit into from
Feb 10, 2023

Conversation

@NewByVector
Copy link
Contributor

Description

Close #3134

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added size/M labels Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023 •
edited
Loading

Codecov Report

Merging #3225 (84d1f29) into master (1cf9cb6) will not change coverage.
The diff coverage is 27.27%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3225   +/-   ##
=======================================
  Coverage   33.07%   33.07%           
=======================================
  Files         274      274           
  Lines       17893    17893           
  Branches     3864     3864           
=======================================
  Hits         5918     5918           
  Misses      11568    11568           
  Partials      407      407
Flag Coverage Δ
x6 18.50% <27.27%> (ø)
x6-common 63.47% <ø> (ø)
x6-geometry 55.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/x6/src/graph/graph.ts 28.94% <27.27%> (ø)

@NewByVector NewByVector merged commit 8fada57 into master Feb 10, 2023
@NewByVector NewByVector deleted the fix-options branch February 10, 2023 01:57
@x6-bot
Copy link
Contributor

x6-bot bot commented Feb 17, 2023

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

@x6-bot x6-bot bot added the released label Feb 17, 2023
@x6-bot
Copy link
Contributor

x6-bot bot commented Feb 24, 2023

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Padding option in centerCell method isn't working inX6 v2

2 participants

@NewByVector