fix: dom matrix tests #4721
fix: dom matrix tests #4721
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @lxfu1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the reliability and accuracy of DOM matrix-related functionalities by fixing and enhancing their corresponding tests. It involves enabling previously skipped test cases, significantly overhauling the mocking of DOMMatrix and SVGMatrix APIs in the test setup to better reflect real browser behavior, and refining the core utility for creating SVG matrices. The changes ensure that matrix transformations are correctly applied and validated, leading to more robust and predictable graphical operations.
Highlights
- Test Suite Activation: The pull request enables previously skipped DOM matrix tests, ensuring that critical transformation logic is now thoroughly validated.
- Enhanced DOM Matrix Mocking: The mocking of DOMMatrix and SVGMatrix APIs within the test environment has been significantly upgraded, providing more accurate and comprehensive simulations of browser-native matrix operations, including complex transformations and the
getCTMmethod. - Core Utility Refinement: The utility function for creating SVG matrices in the source code has been refined to ensure proper and explicit initialization of matrix properties from input objects.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes and enables a previously skipped test suite for DOM matrix functionality. The changes are mostly in the test setup, where incomplete and buggy mocks for SVGMatrix and getCTM have been replaced with much more robust and correct implementations. This is a great improvement for test reliability.
My review includes two points:
- A fix for a bug in a new polyfill for
DOMMatrix.prototype.scaleinsetup-env.ts. - Removal of dead code in
src/common/dom/matrix.tsto improve maintainability.
Overall, this is a solid contribution to improving the test suite.
| if (!(DOMMatrix.prototype as any).scale) { | ||
| DOMMatrix.prototype.scale = function (s: number) { | ||
| const m = this.clone() | ||
| m.scaleSelf(s) | ||
| return m | ||
| } | ||
| } |
There was a problem hiding this comment.
The polyfill for DOMMatrix.prototype.scale only accepts a single argument for uniform scaling. However, it's being used for non-uniform scaling in both the tests (e.g., scale(2, 3)) and the scaleNonUniform polyfill. This can lead to incorrect behavior where the sy factor is ignored.
The scale method should be updated to accept both sx and sy arguments to correctly handle non-uniform scaling. The DOMMatrix.scaleSelf() method correctly handles an undefined sy by defaulting it to sx.
| if (!(DOMMatrix.prototype as any).scale) { | |
| DOMMatrix.prototype.scale = function (s: number) { | |
| const m = this.clone() | |
| m.scaleSelf(s) | |
| return m | |
| } | |
| } | |
| if (!(DOMMatrix.prototype as any).scale) { | |
| DOMMatrix.prototype.scale = function (sx: number, sy?: number) { | |
| const m = this.clone() | |
| m.scaleSelf(sx, sy) | |
| return m | |
| } | |
| } |
b42a963 to
4108446
Compare
Description
Motivation and Context
Types of changes
Self Check before Merge