chore(ledger): switch to rand=0.9.2 and rand_chacha=0.9.0 #9033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9033 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 862 862
Lines 326716 326716
=======================================
+ Hits 267614 267648 +34
+ Misses 59102 59068 -34 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
randcrate with version >=0.9 fixes problem withgenfunction name colliding with keyword reserved in Rust 2024 edition (it doesn't strictly block Upgrade rust edition to 2024 #6203, but seems like a better way to hit two birds with one stone)randDue to the last point we might be better off with updating rand incrementally (compare with previous attempt of upgrading in #4721).
Summary of Changes
Switch ledger to
rand0.9.2 andrand_chachato 0.9.0 (closely coupled withrand, they both rely on same version ofrand_core)