Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yihau
Copy link
Member

@yihau yihau commented Nov 12, 2025

Problem

(split from #9025)

These two commands don't work on the tip of master. They should be caught by the frozen-abi test. However they don't. I'll dig deeper to understand why.

cargo +nightly-2025-06-23 test --features frozen-abi -p agave-votor-messages
cargo +nightly-2025-06-23 test --features frozen-abi -p agave-votor

Summary of Changes

add missing enabling

"solana-ledger/frozen-abi",
"solana-runtime/frozen-abi",
"solana-signature/frozen-abi",
"agave-votor-messages/frozen-abi",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to sort the list here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's address it with another PR for the all cargo toml format 🫑

@codecov-commenter
Copy link

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 81.9%. Comparing base (93a9d2a) to head (ff8f503).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #9034     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         862      862             
  Lines      326716   326716             
=========================================
- Hits       267614   267607      -7     
- Misses      59102    59109      +7     
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yihau yihau added this pull request to the merge queue Nov 12, 2025
Merged via the queue into anza-xyz:master with commit 6d6740f Nov 12, 2025
51 checks passed
@yihau yihau deleted the add-missing-frozen-abi branch November 12, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants