refactor: move SocketAddrSpace to net-utils #9035
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move SocketAddrSpace from solana-streamer to solana-net-utils where it logically belongs. This reduces unnecessary dependencies on the streamer crate for code that only needs address space validation. Changes: - Move SocketAddrSpace enum and implementation to net-utils - Update all req files to import from new location - Add deprecation warning to streamer re-export for backward compatibility - Remove socket module from streamer's public API Fixes anza-xyz#9027 Signed-off-by: AvhiMaz <[email protected]>
|
Unfortunately, the issue was already claimed by a different contributor before you have indicated interest. To deconflict the development efforts, you could take a look at e.g. #9032 (but please post on the issue that you are working on a fix before committing actual dev effort). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SocketAddrSpace struct is not streamer-specific but resides in solana-streamer crate, forcing unnecessary dependencies on the entire streamer crate for code that only needs address space validation.
Summary of Changes
Fixes #9027