-
Notifications
You must be signed in to change notification settings - Fork 144
Open
Description
Crates splitting is a bit too extreme at the moment IMO, some types are required when using a crate, but they are defined elsewhere and has to be imported separately, this will cause problem when you have more major versions in the future, because the crates need to be compatible with each other.
Some examples:
solana-signer: Pubkey and Signature types is inSignertrait definitionsolana-keypair: should add a newsignerfeature flag to gateimpl Signer, and re-export needed type when the feature is activated.solana-client:CommitmentConfig,Signature,Pubkey
There are probably many more.
There is also ergonomic problems, e.g. if my code need to sign a message, I have to import 4 crates: keypair, pubkey, signature, signer;
Metadata
Metadata
Assignees
Labels
No labels