cqssrt log field for TLS resumption type #12404
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d936c18 to
22e113e
Compare
This applies to the cqssu (curve) and cqssg (group name) TLS log fields. This does two things: * Updates server session caching logic to provide the TLS group name on resumption. * Updates the logging of the curve and group name for ticket resumption logic so that the TLS curve and group names are properly retrieved from the SSL object. For ticket resumption, there is no curve/group name stored to retrieve. It is properly retrieved from the SSL object. Before this change: (1) the SSL group was always retrieved from the SSL object when it should have been retrieved from the server session cache ex_data for session cache resumption and (2) the curve value for cqssu was alway "-" for TLS ticket resumption because there was no cached value to retrieve like there is with server session caching. Fixes: apache#12398
This adds the cqssrt log field that indicates the TLS resumption type: 0: no resumption 1: server session cache resumption 2: TLS ticket resumption
22e113e to
6a2002a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the cqssrt log field that indicates the TLS resumption type:
0: no resumption
1: server session cache resumption
2: TLS ticket resumption
Draft
Starting this out as a draft until the dependand #12393 lands. Note this PR is only for the latest commit of the two in here.