Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kingsword09
Copy link
Contributor

Which issue does this PR close?

Closes #6163.

Rationale for this change

What changes are included in this PR?

The append methods have been deprecated and replaced with the write method using WriteOptions.builder().append(true).build().

Are there any user-facing changes?

@kingsword09 kingsword09 requested a review from tisonkun as a code owner May 11, 2025 02:35
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" labels May 11, 2025
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

I'd suggest you remove the rust part code also, and actually you can remove these Java method as well with proper upgrade.md changelog.

@kingsword09 kingsword09 force-pushed the refactor-asyncoperator-append-merge-into-write branch from 7e6be9b to e5f145b Compare May 12, 2025 02:08
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels May 12, 2025
@kingsword09
Copy link
Contributor Author

Thanks for your contribution!

I'd suggest you remove the rust part code also, and actually you can remove these Java method as well with proper upgrade.md changelog.

Thanks for the feedback! I've updated the PR according to your suggestions.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Generally looks good. IIRC you can do the same for the (blocking) Operator?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 12, 2025
@kingsword09
Copy link
Contributor Author

Great!

Generally looks good. IIRC you can do the same for the (blocking) Operator?

I checked the (blocking) Operator and it seems to have no standalone append method.

@tisonkun
Copy link
Member

Great!
Generally looks good. IIRC you can do the same for the (blocking) Operator?

I checked the (blocking) Operator and it seems to have no standalone append method.

Interesting. Thanks for looking into this.

Then we should be good to merge. Merging ...

@tisonkun tisonkun changed the title refactor(bindings/java): AsyncOperator deprecate append methods in favor of write with WriteOptions where append = true (#6163) refactor(bindings/java): deprecate append in favor of write with append=true May 12, 2025
@tisonkun tisonkun merged commit a85dfa1 into apache:main May 12, 2025
65 checks passed
@kingsword09 kingsword09 deleted the refactor-asyncoperator-append-merge-into-write branch May 12, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dedicated append method in Java binding can be merged into write with WriteOption

2 participants