-
Notifications
You must be signed in to change notification settings - Fork 283
feat(image): add --docker-host option for GH Action users
#267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5ad2b81 to
129ed55
Compare
|
Would you be able to get this merged back to Thanks! |
|
@admiralAwkbar it's not up to me, but @simar7 |
simar7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, lgtm! sorry about the delay in reviewing.
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [aquasecurity/trivy-action](https://togithub.com/aquasecurity/trivy-action) | action | minor | `0.19.0` -> `0.24.0` | --- ### Release Notes <details> <summary>aquasecurity/trivy-action (aquasecurity/trivy-action)</summary> ### [`v0.24.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.24.0) [Compare Source](https://togithub.com/aquasecurity/trivy-action/compare/0.23.0...0.24.0) #### What's Changed - Upgrade trivy to v0.53.0 by [@​Dr-DevOps](https://togithub.com/Dr-DevOps) in [https://github.com/aquasecurity/trivy-action/pull/369](https://togithub.com/aquasecurity/trivy-action/pull/369) **Full Changelog**: aquasecurity/trivy-action@0.23.0...0.24.0 ### [`v0.23.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.23.0) [Compare Source](https://togithub.com/aquasecurity/trivy-action/compare/0.22.0...0.23.0) #### What's Changed - Upgrade trivy to v0.52.2 by [@​Dr-DevOps](https://togithub.com/Dr-DevOps) in [https://github.com/aquasecurity/trivy-action/pull/367](https://togithub.com/aquasecurity/trivy-action/pull/367) **Full Changelog**: aquasecurity/trivy-action@0.22.0...0.23.0 ### [`v0.22.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.22.0) [Compare Source](https://togithub.com/aquasecurity/trivy-action/compare/0.21.0...0.22.0) #### What's Changed - chore(docs): Reference the use of a pinned version by [@​simar7](https://togithub.com/simar7) in [https://github.com/aquasecurity/trivy-action/pull/356](https://togithub.com/aquasecurity/trivy-action/pull/356) - Upgrade trivy to v0.52.0 by [@​Keralin](https://togithub.com/Keralin) in [https://github.com/aquasecurity/trivy-action/pull/364](https://togithub.com/aquasecurity/trivy-action/pull/364) #### New Contributors - [@​Keralin](https://togithub.com/Keralin) made their first contribution in [https://github.com/aquasecurity/trivy-action/pull/364](https://togithub.com/aquasecurity/trivy-action/pull/364) **Full Changelog**: aquasecurity/trivy-action@0.21.0...0.22.0 ### [`v0.21.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.21.0) [Compare Source](https://togithub.com/aquasecurity/trivy-action/compare/0.20.0...0.21.0) #### What's Changed - bump trivy version to v0.51.2 by [@​Dr-DevOps](https://togithub.com/Dr-DevOps) in [https://github.com/aquasecurity/trivy-action/pull/360](https://togithub.com/aquasecurity/trivy-action/pull/360) #### New Contributors - [@​Dr-DevOps](https://togithub.com/Dr-DevOps) made their first contribution in [https://github.com/aquasecurity/trivy-action/pull/360](https://togithub.com/aquasecurity/trivy-action/pull/360) **Full Changelog**: aquasecurity/trivy-action@0.20.0...0.21.0 ### [`v0.20.0`](https://togithub.com/aquasecurity/trivy-action/releases/tag/0.20.0) [Compare Source](https://togithub.com/aquasecurity/trivy-action/compare/0.19.0...0.20.0) ##### What's Changed - Make 'hide-progress' input working again by [@​uridium](https://togithub.com/uridium) in [https://github.com/aquasecurity/trivy-action/pull/323](https://togithub.com/aquasecurity/trivy-action/pull/323) - feat(image): add `--docker-host` option for GH Action users by [@​calinmarina](https://togithub.com/calinmarina) in [https://github.com/aquasecurity/trivy-action/pull/267](https://togithub.com/aquasecurity/trivy-action/pull/267) - Browse Trivy reports without GitHub Advanced Security license by [@​uridium](https://togithub.com/uridium) in [https://github.com/aquasecurity/trivy-action/pull/328](https://togithub.com/aquasecurity/trivy-action/pull/328) - Fix docker host bug by [@​admiralAwkbar](https://togithub.com/admiralAwkbar) in [https://github.com/aquasecurity/trivy-action/pull/329](https://togithub.com/aquasecurity/trivy-action/pull/329) - Bump trivy version to v0.50.2 by [@​pdefreitas](https://togithub.com/pdefreitas) in [https://github.com/aquasecurity/trivy-action/pull/341](https://togithub.com/aquasecurity/trivy-action/pull/341) - update tests by [@​nikpivkin](https://togithub.com/nikpivkin) in [https://github.com/aquasecurity/trivy-action/pull/334](https://togithub.com/aquasecurity/trivy-action/pull/334) - bump trivy version to v0.51.1 by [@​simar7](https://togithub.com/simar7) in [https://github.com/aquasecurity/trivy-action/pull/353](https://togithub.com/aquasecurity/trivy-action/pull/353) ##### New Contributors - [@​uridium](https://togithub.com/uridium) made their first contribution in [https://github.com/aquasecurity/trivy-action/pull/323](https://togithub.com/aquasecurity/trivy-action/pull/323) - [@​calinmarina](https://togithub.com/calinmarina) made their first contribution in [https://github.com/aquasecurity/trivy-action/pull/267](https://togithub.com/aquasecurity/trivy-action/pull/267) - [@​admiralAwkbar](https://togithub.com/admiralAwkbar) made their first contribution in [https://github.com/aquasecurity/trivy-action/pull/329](https://togithub.com/aquasecurity/trivy-action/pull/329) - [@​pdefreitas](https://togithub.com/pdefreitas) made their first contribution in [https://github.com/aquasecurity/trivy-action/pull/341](https://togithub.com/aquasecurity/trivy-action/pull/341) **Full Changelog**: aquasecurity/trivy-action@0.19.0...0.20.0 </details> --- ### Configuration π **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/newrelic/helm-charts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNDAuMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy40MjUuMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This is addressing problem arising from trying to scan local images when docker socket path is different than default
/var/run/docker.sockThis was already requested and solved here aquasecurity/trivy#2997 for CLI runs but not available for trivy GH Action.
Adds test and fixes outdated ones.