Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Broken specs #43

@jcf

Description

@jcf

To start an Arachne application with instrumentation enabled requires the following spec changes:

;; Before
(s/fdef arachne.core.config/update
  :args (s/cat :config ::config, :txdata ::txdata)
  :ret ::config)

;; After with provenance added
(s/fdef arachne.core.config/update
  :args (s/cat :config ::config
               :txdata ::txdata
               :add-provenance-txdata? (s/? boolean?))
  :ret ::config)

;; Before
(s/fdef arachne.core.config/q
  :args (s/cat :config ::config,
               :find-expr ::find-expr,
               :sources (s/or :not-present nil?
                              :varargs coll?)))

;; After with a more lax `:sources` spec
(s/fdef arachne.core.config/q
  :args (s/cat :config ::config,
               :find-expr ::find-expr,
               :sources (s/? any?)))

I've added the provenance txdata boolean to update, and changed :sources on q to allow any varargs (the any? could be a spec for whatever the other sources are).

I can open a PR with the above spec changes if you like.

Thanks for your work on Arachne, @levand!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions