Thanks to visit codestin.com
Credit goes to github.com

Skip to content

rockchip64-6.16: update rkvdec driver with HEVC, VDPU38X support #8574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2025
Merged

rockchip64-6.16: update rkvdec driver with HEVC, VDPU38X support #8574

merged 2 commits into from
Sep 4, 2025

Conversation

@amazingfate
Copy link
Contributor

Description

There are two patch series for rkvdec:

And collabora has a rebase branch of these two series: https://gitlab.collabora.com/detlev/linux/-/commits/add-vdpu381-and-383-to-rkvdec-v3

Collabora's patch series said that a patch for gstreamer is necessary for HEVC videos with short and long term reference set information: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/9355, from my test gstreamer without the patch won't crash when playing.

To make chromium decoding work I add a new patch media-0002-revert-rkvdec_s_ctrl.patch to fix the issue introduced by this commit since v6.16: torvalds/linux@d35c64e

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • ./compile.sh kernel BOARD=armsom-sige7 BRANCH=edge KERNEL_CONFIGURE=no DEB_COMPRESS=xz KERNEL_BTF=yes KERNEL_GIT=shallow
  • tested with chromium/gstreamer

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 3, 2025 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (5)
  • patch/kernel/archive/rockchip64-6.16/general-v4l2-rkvdec-01-vp9.patch.disabled is excluded by !patch/**
  • patch/kernel/archive/rockchip64-6.16/media-0000-Unstage-rkvdec.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip64-6.16/media-0001-Add-rkvdec-Support-v5.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip64-6.16/media-0001-Add-rkvdec2-Support-v3.patch is excluded by !patch/**
  • patch/kernel/archive/rockchip64-6.16/media-0002-media-rkvdec-remove-vb2_is_busy-check-in-rkvdec_s_ct.patch is excluded by !patch/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... 11 Milestone: Fourth quarter release labels Sep 3, 2025
HeyMeco
HeyMeco approved these changes Sep 3, 2025
View reviewed changes
Copy link
Collaborator

@HeyMeco HeyMeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven’t tested it on hardware but looks good to me.

@leggewie
Copy link
Collaborator

leggewie commented Sep 3, 2025

Thank you for your work.

Would you be willing to add some meta-information to your patch so that it becomes easier to track in the future. DEP-3 might be a guideline if you are familiar with it.

@amazingfate
Copy link
Contributor Author

Thank you for your work.

Would you be willing to add some meta-information to your patch so that it becomes easier to track in the future. DEP-3 might be a guideline if you are familiar with it.

The patches from mailing list is generated by git format-patch, I will add git commit msg to media-0002-revert-rkvdec_s_ctrl.patch.

@leggewie leggewie merged commit 4f26990 into armbian:main Sep 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HeyMeco HeyMeco HeyMeco approved these changes

@chainsx chainsx chainsx approved these changes

@ColorfulRhino ColorfulRhino Awaiting requested review from ColorfulRhino ColorfulRhino is a code owner

@JohnTheCoolingFan JohnTheCoolingFan Awaiting requested review from JohnTheCoolingFan JohnTheCoolingFan is a code owner

@SuperKali SuperKali Awaiting requested review from SuperKali SuperKali is a code owner

@TRSx80 TRSx80 Awaiting requested review from TRSx80 TRSx80 is a code owner

@TheSnowfield TheSnowfield Awaiting requested review from TheSnowfield TheSnowfield is a code owner

@Tonymac32 Tonymac32 Awaiting requested review from Tonymac32 Tonymac32 is a code owner

@ahoneybun ahoneybun Awaiting requested review from ahoneybun ahoneybun is a code owner

@brentr brentr Awaiting requested review from brentr brentr is a code owner

@catalinii catalinii Awaiting requested review from catalinii catalinii is a code owner

@clee clee Awaiting requested review from clee clee is a code owner

@efectn efectn Awaiting requested review from efectn efectn is a code owner

@igorpecovnik igorpecovnik Awaiting requested review from igorpecovnik igorpecovnik is a code owner

@joekhoobyar joekhoobyar Awaiting requested review from joekhoobyar joekhoobyar is a code owner

@krachlatte krachlatte Awaiting requested review from krachlatte krachlatte is a code owner

@lanefu lanefu Awaiting requested review from lanefu lanefu is a code owner

@paolosabatino paolosabatino Awaiting requested review from paolosabatino paolosabatino is a code owner

@prahal prahal Awaiting requested review from prahal prahal is a code owner

@pyavitz pyavitz Awaiting requested review from pyavitz pyavitz is a code owner

@rpardini rpardini Awaiting requested review from rpardini rpardini is a code owner

@schwar3kat schwar3kat Awaiting requested review from schwar3kat schwar3kat is a code owner

Assignees

No one assigned

Labels

11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/large PR with 250 lines or more

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amazingfate @leggewie @HeyMeco @chainsx