Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JerrysShan
Copy link
Collaborator

close #34

Copy link
Member

@noahziheng noahziheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
有个点留个记录,后续需要补充文档,对于 value/type/factory 取值的优先级次序需要给出明确说明,现在其实是隐式的

@fengmk2
Copy link
Member

fengmk2 commented Jul 5, 2022

才发现我们的代码缩进是 tab 。。。为啥没有选择 js 社区的 2 空格?

@JerrysShan
Copy link
Collaborator Author

才发现我们的代码缩进是 tab 。。。为啥没有选择 js 社区的 2 空格?

现在 artus 还没有配置统一的 eslint 规则,现在走了本地默认的 prettier 规则

@JerrysShan
Copy link
Collaborator Author

artusjs/eslint-config-artus#1 @XadillaX 帮忙看下,或者把权限开通下

@JerrysShan
Copy link
Collaborator Author

先合并,后续提个 PR 把 eslint 规则加上,统一格式化代码

@JerrysShan JerrysShan merged commit c52a680 into artusjs:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: 支持工厂模式

4 participants