Read Action multitenancy :bypass_all #2154
Conversation
|
I like the idea, but I think we're going to have to do it with shared context. The tenant can be any value, so for all we know |
That makes sense |
- reading the tenancy configuration from the shared context - cascading the same configurations to the nested actions
…pdate, destroy and generic actions
| {:ok, %{query | tenant: nil, to_tenant: nil}} | ||
|
|
||
| :bypass_all -> | ||
| query = Ash.Query.set_context(query, %{shared: %{multitenancy: :bypass_all}}) |
There was a problem hiding this comment.
using shared context means it will apply to all children, regardless of how deep they are nested. Is this the intent? IIRC you made a good point about it being less confusing if it only extends to direct relationships.
There was a problem hiding this comment.
yeah I think that was uncertain and you wanted this type of behavior. I think it can be confusing in both ways.
This pattern grew on me because it could be easier to debug knowing the all the descending queries will be untenanted instead of having to check each intermediate step. You know you users better so I'll leave the final decision to you.
|
🚀 Thank you for your contribution! 🚀 |
Always! |
This PR allows the user to setup a new value
bypass_allfor themultitenancyoption in the read action. Withbypass_allthe user can recursively bypass the tenancy of all the resources successively loaded.Also this PR removes the
bypassvalue from the other actions type since it wasn't actually implemented.Contributor checklist
Leave anything that you believe does not apply unchecked.