chore: Use the same parent query timeout for the count query, for read actions
#2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachdaniel
reviewed
Jun 23, 2025
| {:ok, results} <- run_authorize_results(query, results), | ||
| {:ok, results, after_notifications} <- run_after_action(query, results), | ||
| {:ok, count} <- maybe_await(count) do | ||
| {:ok, count} <- maybe_await(count, query.timeout) do |
Contributor
There was a problem hiding this comment.
It may not necessarily have a timeout, so we would likely want to do something like query.timeout || :infinity. Unless we set query.timeout to infinity automatically or something?
Contributor
Author
There was a problem hiding this comment.
I'm not sure tbh, but in my testing if I didn't set a timeout, it was infinity?
Contributor
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Slack.
When supplying the
timeoutoption toAsh.read, that timeout is not being used for thecountquery that also gets run (when fetching a total count, for pagination purposes).Doing some testing via a Cinder table (as that's what the original error was coming from), when specifying
query_opts={[timeout: 10000]}this gets passed through to thecountquery.If no
timeoutis specified from the table,query.timeoutis:infinity.Contributor checklist
Leave anything that you believe does not apply unchecked.