improvement: allow pure-binary sigils in expr fragments #2165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachdaniel
previously approved these changes
Jun 25, 2025
lib/ash/expr/expr.ex
Outdated
|
|
||
| def do_expr({:fragment, opts, [{_, _, [{:<<>>, _, [query]}, []]} | rest]}, escape?) | ||
| when is_binary(query) do | ||
| do_expr({:fragment, opts, [Macro.expand(query, __ENV__) | rest]}, escape?) |
Contributor
There was a problem hiding this comment.
So this discards whatever compile time transformations are made by the sigil doesn't it? I think we'd want to pass the AST through right?
Contributor
Author
There was a problem hiding this comment.
Good catch, I made a few changes that should address that properly.
zachdaniel
approved these changes
Jun 26, 2025
Contributor
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.