fix: support top-level :shared key in Ash.Scope.ToOpts for Map
#2261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression in
Ash.Scope.ToOptsimplementation forMapwhere top-level:sharedkeys were not being properly converted to context options.Problem
The
Ash.Scope.ToOptsimplementation forMapwas only checking for:sharednested under a:contextkey:However, the deprecated
Ash.Context.to_opts/1documentation indicates it should handle both patterns, and client code was expecting the top-level pattern to work.Solution
Updated the
get_context/1function inAsh.Scope.ToOptsforMapto check both patterns::contextkey (existing behavior):sharedkey (new behavior)Changes
Ash.Scope.ToOptsimplementation forMapTesting
Contributor Checklist