Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 19, 2018. It is now read-only.

Update flow tests whitelist #770

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Update flow tests whitelist #770

merged 1 commit into from
Oct 24, 2017

Conversation

@existentialism
Copy link
Member

@existentialism existentialism commented Oct 24, 2017 •
edited
Loading

Q A
Bug fix? n
Breaking change? n
New feature? n
Deprecations? n
Spec compliancy? n
Tests added/pass? n/y
Fixed tickets
License MIT

Some new import parsing tests were added in facebook/flow@11eb1f9.

I'll take a look at getting these to pass as well.

nicolo-ribaudo
nicolo-ribaudo approved these changes Oct 24, 2017
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, import { type as as foo } should work but didn't before.

I wonder if tests of the parsers are only an exercise to think about the edgier cases without an actual utility. 😆

@existentialism existentialism merged commit cb6082e into master Oct 24, 2017
@existentialism existentialism deleted the update-flow-whitelist branch October 24, 2017 20:58
@existentialism existentialism mentioned this pull request Oct 27, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: flow Tag: Internal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@existentialism @nicolo-ribaudo