TransferBDD: use verify exception to have a runtime-preserved assertion equivalent #9569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9569 +/- ##
=======================================
Coverage 73.28% 73.28%
=======================================
Files 3335 3335
Lines 170380 170378 -2
Branches 20572 20572
=======================================
- Hits 124857 124856 -1
+ Misses 36376 36375 -1
Partials 9147 9147
🚀 New features to boost your workflow:
|
1638c24 to
32d2bfb
Compare
…on equivalent We eliminated (or should have) this class of bug with #9554 and related fixes. However, use verify (see https://github.com/google/guava/wiki/ConditionalFailuresExplained) instead of java `assert` to provide a better user experience if this were to happen. commit-id:7f03d493
32d2bfb to
441ce2e
Compare
millstein
reviewed
Oct 24, 2025
Contributor
millstein
left a comment
There was a problem hiding this comment.
@millstein reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dhalperi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We eliminated (or should have) this class of bug with #9554 and
related fixes. However, use verify (see
https://github.com/google/guava/wiki/ConditionalFailuresExplained) instead of
java
assertto provide a better user experience if this were to happen.