Thanks to visit codestin.com
Credit goes to github.com

Skip to content

πŸ’… lint/complexity/noUselessFragments - incorrect suggestion if fragment consists only HTML entityΒ #6508

@wojtekmaj

Description

@wojtekmaj

Environment information

CLI:
  Version:                      2.0.0
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  BIOME_THREADS:                unset
  NO_COLOR:                     unset
  TERM:                         xterm-256color
  JS_RUNTIME_VERSION:           v24.0.2
  JS_RUNTIME_NAME:              node
  NODE_PACKAGE_MANAGER:         npm/11.3.0

Biome Configuration:
  Status:                       Loaded successfully
  Path:                         biome.json
  Formatter enabled:            true
  Linter enabled:               true
  Assist enabled:               true
  VCS enabled:                  true

Workspace:
  Open Documents:               0

Rule name

lint/complexity/noUselessFragments

Playground link

In this playground, you can see both my code and what Biome has suggested.

https://biomejs.dev/playground/?code=ZQB4AHAAbwByAHQAIABkAGUAZgBhAHUAbAB0ACAAZgB1AG4AYwB0AGkAbwBuACAAQQBwAHAAKAApACAAewAKACAAIABjAG8AbgBzAHQAIABzAG8AcgB0AEQAaQByAGUAYwB0AGkAbwBuACAAPQAgACcAYQBzAGMAJwA7AAoACgAgACAAYwBvAG4AcwB0ACAAcwBvAHIAdABJAGMAbwBuACAAPQAgACAAcwBvAHIAdABEAGkAcgBlAGMAdABpAG8AbgAgAD0APQA9ACAAIgBhAHMAYwAiACAAPwAgADwAPgAmACMAOQA2ADUAMAA7ADwALwA%2BACAAOgAgADwAPgAmACMAOQA2ADYAMAA7ADwALwA%2BADsACgAKACAAIABjAG8AbgBzAHQAIABzAG8AcgB0AEkAYwBvAG4AQQBzAFMAdQBnAGcAZQBzAHQAZQBkAEIAeQBCAGkAbwBtAGUAIAA9ACAAcwBvAHIAdABEAGkAcgBlAGMAdABpAG8AbgAgAD0APQA9ACAAIgBhAHMAYwAiACAAPwAgACIAJgAjADkANgA1ADAAOwAiACAAOgAgACIAJgAjADkANgA2ADAAOwAiADsACgAgACAACgAgACAAcgBlAHQAdQByAG4AIAAoAAoAIAAgACAAIAA8AGQAaQB2ACAAYwBsAGEAcwBzAE4AYQBtAGUAPQAiAEEAcABwACIAPgAKACAAIAAgACAAIAAgADwAaAAyAD4AUwBvAHIAdAAgAGkAYwBvAG4APAAvAGgAMgA%2BAAoAIAAgACAAIAAgACAAewBzAG8AcgB0AEkAYwBvAG4AfQAKACAAIAAgACAAIAAgADwAaAAyAD4AUwBvAHIAdAAgAGkAYwBvAG4AIABhAHMAIABzAHUAZwBnAGUAcwB0AGUAZAAgAGIAeQAgAEIAaQBvAG0AZQA8AC8AaAAyAD4ACgAgACAAIAAgACAAIAB7AHMAbwByAHQASQBjAG8AbgBBAHMAUwB1AGcAZwBlAHMAdABlAGQAQgB5AEIAaQBvAG0AZQB9AAoAIAAgACAAIAA8AC8AZABpAHYAPgAKACAAIAApADsACgB9AAoA&ruleDomains.react=recommended

In this CodeSandbox, the exact same code is ran, showcasing how following Biome's advice breaks the UI.

https://codesandbox.io/p/sandbox/5m3c25

Expected result

Biome not to suggest removing a fragment where resulting HTML would differ, e.g. when there are HTML entities inside (possibly there might be more cases like this?)

Code of Conduct

  • I agree to follow Biome's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    S-Needs triageStatus: this issue needs to be triaged

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions