-
-
Notifications
You must be signed in to change notification settings - Fork 731
Labels
A-CLIArea: CLIArea: CLIS-Bug-confirmedStatus: report has been confirmed as a valid bugStatus: report has been confirmed as a valid bug
Description
Environment information
CLI:
Version: 2.1.1
Color support: true
Platform:
CPU Architecture: x86_64
OS: linux
Environment:
BIOME_LOG_PATH: unset
BIOME_LOG_PREFIX_NAME: unset
BIOME_CONFIG_PATH: unset
BIOME_THREADS: unset
NO_COLOR: unset
TERM: xterm-256color
JS_RUNTIME_VERSION: v22.11.0
JS_RUNTIME_NAME: node
NODE_PACKAGE_MANAGER: unset
Biome Configuration:
Status: Not set
Path: unset
Workspace:
Open Documents: 0
What happened?
biome ci --assist-enabled=false doesn't seem to be honored if the repo contains multiple biome configs (monorepo).
Tested with latest 2.1.1 as well as latest head (c9e969a)
Example:
git clone https://github.com/sebcode/biometest.git
cd biometest
biome ci --formatter-enabled=true --linter-enabled=false --assist-enabled=false --enforce-assist=false
Outputs:
module/src/index.ts:1:1 assist/source/organizeImports FIXABLE ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
βΉ The imports and exports are not sorted.
> 1 β import B from './b'
β ^^^^^^^^^^^^^^^^^^^
2 β import A from './a'
3 β
βΉ Safe fix: Organize Imports (Biome)
1 β - importΒ·BΒ·fromΒ·'./b'
2 β - importΒ·AΒ·fromΒ·'./a'
1 β + importΒ·AΒ·fromΒ·'./a'
2 β + importΒ·BΒ·fromΒ·'./b'
3 3 β
4 4 β export { A, B }
module/src/a.ts format βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
β File content differs from formatting output
1 β - exportΒ·defaultΒ·functionΒ·a()Β·{Β·console.log('a')Β·}
1 β + exportΒ·defaultΒ·functionΒ·a()Β·{
2 β + Β·Β·console.log('a')
3 β + }
2 4 β
Checked 4 files in 2ms. No fixes applied.
Found 1 error.
ci βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
β Some errors were emitted while running checks.
Expected result
I would expect the formatting output error, but not the assist/source/organizeImports error:
src/b.ts format ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
β File content differs from formatting output
1 β - exportΒ·defaultΒ·functionΒ·a()Β·{Β·console.log('a')Β·}
1 β + exportΒ·defaultΒ·functionΒ·a()Β·{
2 β + Β·Β·console.log('a')
3 β + }
2 4 β
Checked 4 files in 1547Β΅s. No fixes applied.
Found 1 error.
ci βββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
β Some errors were emitted while running checks.
Code of Conduct
- I agree to follow Biome's Code of Conduct
Metadata
Metadata
Assignees
Labels
A-CLIArea: CLIArea: CLIS-Bug-confirmedStatus: report has been confirmed as a valid bugStatus: report has been confirmed as a valid bug