Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Netail
Copy link
Member

@Netail Netail commented Nov 3, 2025

Summary

Fetch graphql options for test

Test Plan

Docs

@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2025

⚠️ No Changeset found

Latest commit: ed08fa3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-Project Area: project A-Linter Area: linter labels Nov 3, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 3, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request fixes a test options JSON $schema path, integrates rule-based configuration into the GraphQL file handler by creating an AnalyzerConfiguration from to_analyzer_rules(...) and applying it to AnalyzerOptions, renames an internal parameter from _global to global, and adds Maikel to the Maintainers team in CONTRIBUTING.md. No public API or exported signatures were changed.

Suggested reviewers

  • ematipico

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title mentions 'graphql tests options' which aligns with the main changes: updating GraphQL test configuration and adding rule-based configuration to GraphQL analyzer options.
Description check ✅ Passed The description 'Fetch graphql options for test' directly relates to the changeset, which adds GraphQL analyzer configuration and updates test options.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e91222f and ed08fa3.

📒 Files selected for processing (1)
  • CONTRIBUTING.md (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was easy

@Netail Netail merged commit bf6b3c2 into biomejs:main Nov 4, 2025
12 of 13 checks passed
@Netail Netail deleted the chore/graphql-test-options branch November 4, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Linter Area: linter A-Project Area: project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants