Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(html): fix comment detection in Astro frontmatter #7989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
Merged

fix(html): fix comment detection in Astro frontmatter #7989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e48080
fix(html): fix comment detection in Astro frontmatter quotes
alissonlauffer Nov 4, 2025
d11b3f7
Update .changeset/fix-astro-frontmatter-comments.md
ematipico Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .changeset/fix-astro-frontmatter-comments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
"@biomejs/biome": patch
---

Fixed a regression in Astro frontmatter parsing where comments inside quoted strings were incorrectly detected as actual comments. This caused the parser to prematurely terminate frontmatter parsing when encountering strings like `const test = "//";`.
For example, the following Astro frontmatter now parses correctly:

```astro
---
const test = "// not a real comment";
---
```
9 changes: 7 additions & 2 deletions crates/biome_html_parser/src/lexer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,8 +1056,13 @@ impl QuotesSeen {
return; // Don't track quotes inside comments
}

// Check for comment entry
if self.prev_byte == Some(b'/') && (byte == b'/' || byte == b'*') {
// Check for comment entry - but only if we're not inside quotes
if self.prev_byte == Some(b'/')
&& (byte == b'/' || byte == b'*')
&& self.single == 0
&& self.double == 0
&& self.template == 0
{
self.inside_comment = true;
self.prev_byte = Some(byte);
return;
Expand Down
5 changes: 5 additions & 0 deletions crates/biome_html_parser/tests/html_specs/ok/astro/comment_in_frontmatter.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
const test = "//";
---

<div>{test}</div>
96 changes: 96 additions & 0 deletions crates/biome_html_parser/tests/html_specs/ok/astro/comment_in_frontmatter.astro.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
---
source: crates/biome_html_parser/tests/spec_test.rs
expression: snapshot
---
## Input

```astro
---
const test = "//";
---

<div>{test}</div>

```


## AST

```
HtmlRoot {
bom_token: missing (optional),
frontmatter: AstroFrontmatterElement {
l_fence_token: [email protected] "---" [] [],
content: AstroEmbeddedContent {
content_token: [email protected] "const test = \"//\";\n" [Newline("\n")] [],
},
r_fence_token: [email protected] "---" [] [],
},
directive: missing (optional),
html: HtmlElementList [
HtmlElement {
opening_element: HtmlOpeningElement {
l_angle_token: [email protected] "<" [Newline("\n"), Newline("\n")] [],
name: HtmlTagName {
value_token: [email protected] "div" [] [],
},
attributes: HtmlAttributeList [],
r_angle_token: [email protected] ">" [] [],
},
children: HtmlElementList [
HtmlSingleTextExpression {
l_curly_token: [email protected] "{" [] [],
expression: HtmlTextExpression {
html_literal_token: [email protected] "test" [] [],
},
r_curly_token: [email protected] "}" [] [],
},
],
closing_element: HtmlClosingElement {
l_angle_token: [email protected] "<" [] [],
slash_token: [email protected] "/" [] [],
name: HtmlTagName {
value_token: [email protected] "div" [] [],
},
r_angle_token: [email protected] ">" [] [],
},
},
],
eof_token: [email protected] "" [Newline("\n")] [],
}
```

## CST

```
0: [email protected]
0: (empty)
1: [email protected]
0: [email protected] "---" [] []
1: [email protected]
0: [email protected] "const test = \"//\";\n" [Newline("\n")] []
2: [email protected] "---" [] []
2: (empty)
3: [email protected]
0: [email protected]
0: [email protected]
0: [email protected] "<" [Newline("\n"), Newline("\n")] []
1: [email protected]
0: [email protected] "div" [] []
2: [email protected]
3: [email protected] ">" [] []
1: [email protected]
0: [email protected]
0: [email protected] "{" [] []
1: [email protected]
0: [email protected] "test" [] []
2: [email protected] "}" [] []
2: [email protected]
0: [email protected] "<" [] []
1: [email protected] "/" [] []
2: [email protected]
0: [email protected] "div" [] []
3: [email protected] ">" [] []
4: [email protected] "" [Newline("\n")] []

```