feat: improve dev experience with ts-node-dev #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intellix
commented
May 24, 2019
package.json
Outdated
| "resolutions": { | ||
| "typescript": "3.3.1" | ||
| "typescript": "3.3.1", | ||
| "@types/react": "16.8.12" |
There was a problem hiding this comment.
just a note that you need to pin this or else you get this error due to both @types/react@* pulling in 16.8.2 and @types/[email protected]:
@primecms/ui: Failed to compile.
@primecms/ui: /Users/dominicwatson/Sites/github/birkir/prime/packages/prime-ui/node_modules/@types/react/index.d.ts
@primecms/ui: Type error: Duplicate identifier 'LibraryManagedAttributes'. TS2300
@primecms/ui: 2807 | // We can't recurse forever because `type` can't be self-referential;
@primecms/ui: 2808 | // let's assume it's reasonable to do a single React.lazy() around a single React.memo() / vice-versa
@primecms/ui: > 2809 | type LibraryManagedAttributes<C, P> = C extends React.MemoExoticComponent<infer T> | React.LazyExoticComponent<infer T>
@primecms/ui: | ^
@primecms/ui: 2810 | ? T extends React.MemoExoticComponent<infer U> | React.LazyExoticComponent<infer U>
@primecms/ui: 2811 | ? ReactManagedAttributes<U, P>
@primecms/ui: 2812 | : ReactManagedAttributes<T, P>
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=======================================
Coverage 78.14% 78.14%
=======================================
Files 108 108
Lines 2178 2178
Branches 152 152
=======================================
Hits 1702 1702
Misses 458 458
Partials 18 18Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep needing this for other branches and it'll help people get started up in cases like #211