feat: add getter functions for Note hooks #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Add getter functions that complement existing setter functions: - NoteGetFnDebugOutput - NoteGetFnTransaction - NoteGetFnMutex - NoteGetFnI2CMutex - NoteGetFnNoteMutex - NoteGetFn - NoteGetFnSerial - NoteGetFnI2C - NoteGetFnDisabled - NoteGetI2CAddress All getters return void and use pointer-to-pointer parameters.
e4b573c to
91cc55f
Compare
|
Devin is currently unreachable - the session may have died. |
9dcf902 to
91cc55f
Compare
• Added test files for all getter functions in test/src • Each function has its own dedicated test file • Tests follow BDD pattern with SCENARIO blocks • Added all tests to CMakeLists.txt • Tests verify NULL parameter handling • Tests verify valid parameter handling Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Zachary J. Fields <[email protected]>
233f0af to
2a4fe8b
Compare
zfields
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add getter functions for all Note hook setter functions.
Each getter follows the pattern of returning void and using pointer-to-pointer parameters for consistency.
Added functions:
All functions follow a consistent pattern:
Link to Devin run: https://app.devin.ai/sessions/1a3351d408de4183b2f5d15c710f2e11
Requested by: [email protected]