Zak mem drain #104
Merged
Zak mem drain #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Is _Reset() only ever called on error? If not, I would create a helper function _ResetAfterError() which just calls _Reset(). I feel that makes the intent clearer and gives a single point of modification should we want to add additional error handling separate from a "normal" reset. |
m-mcgowan
approved these changes
Sep 26, 2023
ensure reset will consume all available bytes, regardless of the amount. Previously, the 5-second timeout would prevent reset from consuming large outstanding, binary data payloads.
7d07895 to
f6446c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure reset will consume all available bytes,
regardless of the amount. Previously, the 5-second
timeout would prevent reset from consuming large
outstanding, binary data payloads.