Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Doesn't reject invalid quantiles #17

@carbocation

Description

@carbocation

Due to PBKAC, I was inputting quantiles such as []float64{1, 10, 50, 90, 99} rather than []float64{0.01, 0.1, 0.5, 0.9, 0.99}. The program was crashing due to index out of range errors triggered in quantile.(*Stream).Query(), which seems less obvious to me than to receive an error that indicates that my requested quantiles were invalid. There aren't errors returned by NewTargeted() or by Query(), so the changes that seem obvious to me would be API-breaking.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions