Enable futex support in macOS 14.4+ through os_sync_wait_on_address #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Starting with version 14.4, macOS SDK exposes a header that allows to operate with futexes: https://developer.apple.com/documentation/os/os_sync_wait_on_address.
I made a quick change, and it seems to work in my application: with the content of this PR, by defining
BOOST_FIBERS_SPINLOCK_TTAS_FUTEXand an appropriateCMAKE_OSX_DEPLOYMENT_TARGET, I am able to use futex-based synchronisation primitives.On versions prior to 14.4, the code should in principle default to its usual behaviour (pure spinlocks), so this should be a pretty self-contained change. Tests run with
b2 cflags=-mmacosx-version-min=14.4 cxxflags=-mmacosx-version-min=14.4pass, however, I am willing to provide something else for due process, if you have something on your mind.