-
Notifications
You must be signed in to change notification settings - Fork 1
Description
The article "svrep: Replication Methods for Complex Samples and Complex Weighting Methods" presents the R package "svrep" that extends the survey package to more complex sampling methods and bootstrap or other replication schemes. This is the second submission of this article and most comments made on the previous version have been properly addressed. We still found a few issues that need to be fixed before the article can go into review and thus ask that the author then resubmit his work along with a point-by-point answer to raised problems.
Detailed comments:
-
In objects of class 'sim_cv_curve', I am not sure what the entry 'function' is used for: It is never called in internal functions nor illustrated in the replication material. If it does not have a targeted use, it would be best to remove it.
-
Using the example of 'estimate_boot_sim_cv" and testing
x <- estimate_boot_sim_cv(svrepstat=custom_statistic)
plot(x)
gives
Error in xy.coords(x, y, xlabel, ylabel, log) :
'x' is a list, but does not have components 'x' and 'y'